Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add job run UUID to SARIF output #2463

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Add job run UUID to SARIF output #2463

merged 2 commits into from
Sep 5, 2024

Conversation

henrymercer
Copy link
Contributor

This PR adds the job run UUID to the SARIF output to improve the ease of debugging.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 5, 2024 14:00
angelapwen
angelapwen approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DatabaseInterpretResultsSupportsSarifRunProperty is a mouthful but I'm enjoying how descriptive it is 😸

@henrymercer
Copy link
Contributor Author

In retrospect, perhaps we could have dropped the "Supports" :)

@henrymercer henrymercer merged commit ad5c608 into main Sep 5, 2024
311 checks passed
@henrymercer henrymercer deleted the henrymercer/job-uuid-in-sarif branch September 5, 2024 17:34
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Merged
8 tasks
@dbartol dbartol mentioned this pull request Sep 13, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @angelapwen