Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Zstandard bundles on GHES too by default #2573

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

henrymercer
Copy link
Contributor

We're seeing an average 2x speed up by using bundles compressed using Zstandard. Now that this feature has stabilised, this PR rolls it out to GHES, cleans up the feature flags, and removes a mechanism to fall back to gzip that has not been needed.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner November 1, 2024 15:32
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, users will no longer be able to control if they use zstd or tar. I think that's fine since it is not relevant for them if everything works anyway.

@henrymercer
Copy link
Contributor Author

Yeah agreed. Customers can still specify a tools URL if they want to use gzip or zstd. In general I think we want to have flexibility to change the default way the tools are downloaded and installed, e.g. so we can move to per-language bundles.

@henrymercer henrymercer merged commit bfa8cb3 into main Nov 1, 2024
273 checks passed
@henrymercer henrymercer deleted the henrymercer/zstd-bundle-cleanup branch November 1, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants