Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an app token for triggering a release #2644

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

aeisenberg
Copy link
Contributor

We need to do this because using a default token will not recursively trigger a new workflow run.

The only way to test this is to merge to main and do a release.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Copilot Copilot bot review requested due to automatic review settings December 11, 2024 20:41
@aeisenberg aeisenberg requested a review from a team as a code owner December 11, 2024 20:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

.github/workflows/post-release-mergeback.yml:166

  • The new token generation step should be tested to ensure it works as expected. Consider adding a test workflow to validate the token creation process.
uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation doesn't look quite right, but otherwise this looks good!

We need to do this because using a default token will not
recursively trigger a new workflow run.
@aeisenberg aeisenberg force-pushed the aeisenberg/use-app-token-for-release branch from 1a19005 to 9a8645d Compare December 12, 2024 17:10
@aeisenberg
Copy link
Contributor Author

Fixed the indentation. After merging, I will do a release to see if this fixes the problem.

Copy link
Member

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, this looks good.

The only question is whether the permissions are adequate for performing the release, but I guess we won't know until we try it.

@aeisenberg aeisenberg enabled auto-merge December 12, 2024 17:22
@aeisenberg aeisenberg merged commit 9cfbef4 into main Dec 12, 2024
266 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/use-app-token-for-release branch December 12, 2024 17:22
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
8 tasks
@aeisenberg
Copy link
Contributor Author

the permissions are adequate for performing the release

I believe so. We need contents: write for this to work. And the app provides it.

@github-actions github-actions bot mentioned this pull request Dec 12, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants