Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the codeql-action to run packages #545

Merged
merged 15 commits into from
Jun 10, 2021
Merged

Commits on Jun 3, 2021

  1. Allow the codeql-action to run packages

    This commit adds a `packs` option to the codeql-config.yml file. Users
    can specify a list of ql packs to include in the analysis.
    
    For a single language analysis, the packs property looks like this:
    
    ```yaml
    packs:
      - pack-scope/pack-name1@1.2.3
      - pack-scope/pack-name2   # no explicit version means download the latest
    ```
    
    For multi-language analysis, you must key the packs block by lanaguage:
    
    ```yaml
    packs:
      cpp:
        - pack-scope/pack-name1@1.2.3
        - pack-scope/pack-name2
      java:
        - pack-scope/pack-name3@1.2.3
        - pack-scope/pack-name4
    ```
    
    This implementation adds a new analysis run (alongside custom and 
    builtin runs). The unit tests indicate that the correct commands are
    being run, but I have not actually tried this with a real CLI.
    
    Also, convert `instanceof Array` to `Array.isArray` since that is
    sightly better in some situations. See:
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#instanceof_vs_isarray
    aeisenberg committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    86a804f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Configuration menu
    Copy the full SHA
    6cee818 View commit details
    Browse the repository at this point in the history
  2. Fix logic for calculating if there are queries to run

    During the analyze phase.
    aeisenberg committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    9b5753a View commit details
    Browse the repository at this point in the history
  3. Avoid using SemVer instances

    Use strings instead. They are easier to serialize and deserialize.
    aeisenberg committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    06687e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. Configuration menu
    Copy the full SHA
    d87945e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Packaging: Address review comments

    1. Better malformed data guard for PackDownloadOutput
    2. Fix Packs type
    3. Remove TODO in init-action
    aeisenberg committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    1cc5f1d View commit details
    Browse the repository at this point in the history
  2. Add an integration test for packaging

    Uses two pre-existing packages to run some simple queries on a javascript
    database.
    aeisenberg committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    d42f654 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Configuration menu
    Copy the full SHA
    82388fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db01c78 View commit details
    Browse the repository at this point in the history
  3. Refactor codeql.ts

    Extract a `runTool` function that captures the stdout and returns it.
    A small refactoring that reduces copied code.
    aeisenberg committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    49b2220 View commit details
    Browse the repository at this point in the history
  4. Use nullish conversion for packs

    Slightly simplifies the `parsePacks` function.
    aeisenberg committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    96e7de3 View commit details
    Browse the repository at this point in the history
  5. Add pack download to its own log group

    Also, make the baseline count message less awkward sounding.
    aeisenberg committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a2e96a4 View commit details
    Browse the repository at this point in the history
  6. Remove two log entries

    Cleans up the output logs even more. These entries don't add any more
    information since everything is grouped now.
    aeisenberg committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    23cdd6b View commit details
    Browse the repository at this point in the history
  7. Avoid running mergeback workflow on PR

    This was causing the workflow to run and create tags after merging
    main into a branch.
    aeisenberg committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    6a1c070 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Configuration menu
    Copy the full SHA
    20aafcd View commit details
    Browse the repository at this point in the history