Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only attempt to upload on dotcom #565

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

robertbrignull
Copy link
Contributor

(Note this is merging into a feature branch, and not into main)

Only attempt to do anything relating to uploading databases when running against github.com. Thankfully this information is already stored in the config so we can just check that.

Slightly related question, I've been adding these debug logs explaining why we're not uploading. Is that useful? Is it just going to get unnecessary questions about what this is? Not many people run with debug logs enabled, which both means not many people will see it but also it won't be useful to us unless specifically enabled.

@robertbrignull robertbrignull merged commit 69c30da into upload-database Jun 17, 2021
@robertbrignull robertbrignull deleted the robertbrignull/upload_ghes branch June 17, 2021 11:42
This was referenced Jun 21, 2021
This was referenced Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants