Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into v1 #570

Merged
merged 30 commits into from
Jun 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
86a804f
Allow the codeql-action to run packages
aeisenberg Jun 3, 2021
6cee818
Add better comments and error messages for pack-related changes
aeisenberg Jun 4, 2021
9b5753a
Fix logic for calculating if there are queries to run
aeisenberg Jun 4, 2021
06687e9
Avoid using `SemVer` instances
aeisenberg Jun 4, 2021
d87945e
Run the pack download command
aeisenberg Jun 4, 2021
02e8dcf
Fix out of memory in hash computation
edoardopirovano Jun 7, 2021
9e6b46a
Update changelog and version after v1.0.1
invalid-email-address Jun 7, 2021
fbb9046
1.0.2
invalid-email-address Jun 7, 2021
a69f472
Merge branch 'main' into mergeback/v1.0.1-to-main-ece2addc
aeisenberg Jun 7, 2021
9c13fef
Merge pull request #554 from github/mergeback/v1.0.1-to-main-ece2addc
aeisenberg Jun 7, 2021
c095005
Some refactoring in fingerprint computation
edoardopirovano Jun 7, 2021
2cc885d
Replace analyze with run-queries and interpret-results
edoardopirovano Jun 4, 2021
1cc5f1d
Packaging: Address review comments
aeisenberg Jun 7, 2021
d42f654
Add an integration test for packaging
aeisenberg Jun 8, 2021
0ea20c5
Add intepret-results timings to status reports
edoardopirovano Jun 9, 2021
06df98a
Add new log grouping for DB cleanup
edoardopirovano Jun 9, 2021
babcc1b
Add `--finalize-dataset` to `database finalize` call
edoardopirovano Jun 9, 2021
82388fd
Merge remote-tracking branch 'upstream/main' into aeisenberg/pack-run
aeisenberg Jun 9, 2021
db01c78
Remove unneeded action input in PR check
aeisenberg Jun 9, 2021
49b2220
Refactor codeql.ts
aeisenberg Jun 9, 2021
96e7de3
Use nullish conversion for packs
aeisenberg Jun 9, 2021
a2e96a4
Add pack download to its own log group
aeisenberg Jun 9, 2021
23cdd6b
Remove two log entries
aeisenberg Jun 9, 2021
6a1c070
Avoid running mergeback workflow on PR
aeisenberg Jun 9, 2021
20aafcd
Remove unnecessary type assertions
aeisenberg Jun 10, 2021
e284efb
Merge pull request #545 from github/aeisenberg/pack-run
aeisenberg Jun 10, 2021
d16268b
Fix update-release-branch-fix.py
aeisenberg Jun 16, 2021
efea923
Fix custom version of CLI to use for package testing
aeisenberg Jun 16, 2021
0b1f4a0
Merge pull request #566 from github/aeisenberg/update-release-branch-fix
aeisenberg Jun 17, 2021
028a76e
1.0.2
invalid-email-address Jun 17, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/update-release-branch.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def get_commit_difference(repo):

# Is the given commit the automatic merge commit from when merging a PR
def is_pr_merge_commit(commit):
return commit.committer.login == 'web-flow' and len(commit.parents) > 1
return commit.committer is not None and commit.committer.login == 'web-flow' and len(commit.parents) > 1

# Gets a copy of the commit message that should display nicely
def get_truncated_commit_message(commit):
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/post-release-mergeback.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ on:
branches:
- v1

pull_request:
paths:
- .github/workflows/post-release-mergeback.yml

jobs:
merge-back:
runs-on: ubuntu-latest
Expand Down
43 changes: 43 additions & 0 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,49 @@ jobs:
exit 1
fi

# Packaging test that runs against a javascript database
test-packaging-javascript:
needs: [check-js, check-node-modules]
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Move codeql-action
shell: bash
run: |
mkdir ../action
mv * .github ../action/
mv ../action/tests/multi-language-repo/{*,.github} .
mv ../action/.github/workflows .github
- uses: ./../action/init
with:
config-file: ".github/codeql/codeql-config-packaging.yml"
languages: javascript
# TODO: this can be removed when cli v2.5.6 is released and available in the tool cache
tools: https://github.com/dsp-testing/aeisenberg-codeql-action-packaging/releases/download/codeql-bundle-20210615/codeql-bundle-linux64.tar.gz

- name: Build code
shell: bash
run: ./build.sh
- uses: ./../action/analyze
with:
output: "${{ runner.temp }}/results"
env:
TEST_MODE: true
- name: Assert Results
run: |
cd "$RUNNER_TEMP/results"
# We should have 3 hits from these rules
EXPECTED_RULES="javascript/example/empty-or-one-block javascript/example/empty-or-one-block javascript/example/two-block"

# use tr to replace newlines with spaces and xargs to trim leading and trailing whitespace
RULES="$(cat javascript.sarif | jq -r '.runs[0].results[].ruleId' | sort | tr "\n" " " | xargs)"
echo "Found matching rules '$RULES'"
if [ "$RULES" != "$EXPECTED_RULES" ]; then
echo "Did not match expected rules '$EXPECTED_RULES'."
exit 1
fi

# Identify the CodeQL tool versions to integration test against.
check-codeql-versions:
needs: [check-js, check-node-modules]
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# CodeQL Action and CodeQL Runner Changelog

## 1.0.2 - 17 Jun 2021

- Fix out of memory in hash computation. [#550](https://github.com/github/codeql-action/pull/550)
- Clean up logging during analyze results. [#557](https://github.com/github/codeql-action/pull/557)
- Add `--finalize-dataset` to `database finalize` call, freeing up some disk space after database creation. [#558](https://github.com/github/codeql-action/pull/558)

## 1.0.1 - 07 Jun 2021

- Pass the `--sarif-group-rules-by-pack` argument to CodeQL CLI invocations that generate SARIF. This means the SARIF rule object for each query will now be found underneath its corresponding query pack in `runs[].tool.extensions`. [#546](https://github.com/github/codeql-action/pull/546)
Expand Down
3 changes: 3 additions & 0 deletions lib/analysis-paths.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analysis-paths.test.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading