Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original getCodeQLActionRepository behaviour #594

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

simon-engledew
Copy link
Contributor

In version 1.0.0 the logic for determining the getCodeQLActionRepository worked this way round:

https://github.com/github/codeql-action/blob/v1.0.0/src/codeql.ts#L139

In the latest version this logic was reversed during refactoring:

https://github.com/github/codeql-action/blob/v1.0.3/src/codeql.ts#L182

This is currently causing the codeql-runner to break with the error message:

RUNNER_TEMP environment variable must be set.

This PR restores the original behaviour.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@simon-engledew simon-engledew requested a review from a team as a code owner June 24, 2021 16:54
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this bug!

@aeisenberg
Copy link
Contributor

We didn't catch this earlier because all of our integration tests run within actions and the RUNNER_TEMP variable is already set.

@aeisenberg aeisenberg enabled auto-merge June 24, 2021 20:52
@aeisenberg aeisenberg merged commit db80a9a into main Jun 24, 2021
@aeisenberg aeisenberg deleted the simon-engledew/fix-runner-temp-missing branch June 24, 2021 20:58
@github-actions github-actions bot mentioned this pull request Jun 28, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants