Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run the latest tools PR checks so we can make them required #699

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

henrymercer
Copy link
Contributor

This change runs integration tests with all three bundles, even if tools: latest would be the same as tools: null (i.e. omitting the tools property). This allows us to make integration tests against each one of these three tools configurations required status checks on PRs.

As future work, we could move the "$CODEQL_VERSION_DEFAULT" == "$CODEQL_VERSION_LATEST" logic into jobs running with tools: latest to minimise redundant work, or investigate depending on statuses rather than Actions jobs. However right now the additional cost created by these redundant jobs doesn't seem to justify the complexity.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner August 11, 2021 12:05
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrymercer henrymercer merged commit 0d88424 into main Aug 11, 2021
@henrymercer henrymercer deleted the henrymercer/allow-latest-checks-to-be-required branch August 11, 2021 12:32
@github-actions github-actions bot mentioned this pull request Aug 16, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants