Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --ram flag to database finalize #702

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Pass --ram flag to database finalize #702

merged 1 commit into from
Aug 12, 2021

Conversation

edoardopirovano
Copy link
Contributor

@edoardopirovano edoardopirovano commented Aug 12, 2021

This PR passes a RAM option to database finalize, using the same logic to determine what value to use as we do for database run-queries. Currently, without a RAM option the JVM will determine it's own limit which is much more conservative than what we would do (i.e. use most of the memory available) leading to OOM errors during TRAP import for certain projects.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano
Copy link
Contributor Author

@cklin I opted for only using this option with CLI versions >=2.5.9 as, if I recall correctly, the flag was introduced in 2.5.8 but had a bug at that point. Is this correct?

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo the discussion on the correct CodeQL version to check for before passing this flag.

src/util.ts Outdated Show resolved Hide resolved
@cklin
Copy link
Contributor

cklin commented Aug 12, 2021

@cklin I opted for only using this option with CLI versions >=2.5.9 as, if I recall correctly, the flag was introduced in 2.5.8 but had a bug at that point. Is this correct?

The bug fix https://github.com/github/semmle-code/pull/39696/commits/14b72e0439866c662cfdc1a9176ffad23b10a048 went into 2.5.8. And of course 2.5.9 works too.

@edoardopirovano
Copy link
Contributor Author

@cklin I opted for only using this option with CLI versions >=2.5.9 as, if I recall correctly, the flag was introduced in 2.5.8 but had a bug at that point. Is this correct?

The bug fix github/semmle-code@14b72e0 went into 2.5.8. And of course 2.5.9 works too.

Ah, okay, we can use 2.5.8 then! Thanks for checking that 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants