Respect value of LD_PRELOAD
given by the CLI
#817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing its own version of sandwiched tracing, the Action was setting a value of
LD_PRELOAD
. This code stayed outside of the condition for using the new style of tracing (i.e. using sandwiched tracing form the CLI). So, the Action would try to overwrite the value ofLD_PRELOAD
given by the CLI. This should not have been the case - when using the CLI's sandwiched tracing we should use the value ofLD_PRELOAD
provided by the CLI so that the CLI is free to move/rename the libraries as it pleases.Merge / deployment checklist