Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AVA to v4 #822

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 18, 2021

Bumps @ava/typescript from 2.0.0 to 3.0.1.

Release notes

Sourced from @​ava/typescript's releases.

v3.0.1

What's Changed

Full Changelog: avajs/typescript@v3.0.0...v3.0.1

v3.0.0

Requires AVA 4 and supports ES modules.

New Contributors

Full Changelog: avajs/typescript@v2.0.0...v3.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 18, 2021 17:01
@dependabot dependabot bot added the Update dependencies Trigger PR workflow to update dependencies label Nov 18, 2021
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Nov 18, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch 2 times, most recently from b684105 to 9c43038 Compare November 23, 2021 11:33
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch 3 times, most recently from 95327cd to 829cdb3 Compare December 10, 2021 21:42
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch 2 times, most recently from 9846f42 to 10b0d81 Compare January 18, 2022 22:22
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch 2 times, most recently from d4bb43c to 427ceab Compare January 24, 2022 13:35
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch 5 times, most recently from d3a91ad to abe8e36 Compare January 31, 2022 21:39
Bumps [@ava/typescript](https://github.com/avajs/typescript) from 2.0.0 to 3.0.1.
- [Release notes](https://github.com/avajs/typescript/releases)
- [Commits](avajs/typescript@v2.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: "@ava/typescript"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch from abe8e36 to 1163942 Compare February 1, 2022 13:33
@henrymercer henrymercer added the Update dependencies Trigger PR workflow to update dependencies label Feb 1, 2022
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Feb 1, 2022
@henrymercer henrymercer marked this pull request as draft February 1, 2022 17:46
@henrymercer henrymercer marked this pull request as ready for review February 1, 2022 17:46
@henrymercer henrymercer force-pushed the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch from 3273370 to ce89f1b Compare February 1, 2022 18:56
@henrymercer henrymercer changed the title Bump @ava/typescript from 2.0.0 to 3.0.1 Upgrade Ava to v4 Feb 1, 2022
@henrymercer henrymercer changed the title Upgrade Ava to v4 Upgrade AVA to v4 Feb 1, 2022
@henrymercer
Copy link
Contributor

henrymercer commented Feb 1, 2022

@github/codeql-action-reviewers I needed to make some changes to the Action codebase, e.g. adding type annotations, converting macros to use the typed versions, modifying Eslint configuration, to upgrade to AVA 4. Therefore I can't reasonably review this PR myself. Please could one of you take a look?

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. Looks good to me.

So, it seems like for ava > 4, a failing assertion does not end the test, which is a nice feature (I think).

@henrymercer henrymercer merged commit ff33f03 into main Feb 2, 2022
@henrymercer henrymercer deleted the dependabot/npm_and_yarn/ava/typescript-3.0.1 branch February 2, 2022 18:01
@github-actions github-actions bot mentioned this pull request Feb 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants