-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into v1 #874
Merge main into v1 #874
Conversation
Mergeback v1.0.27 refs/heads/v1 into main
Turboscan only allows a single combination of tool name and automation details id for testing category uniqueness. Previously, the check in the action was not entirely correct since it only looked at the _category_ and not the combination of the category and the tool name. It's even more precise now since it is looking at the actual, computed value of the automation details id, rather than an inputted value of the category. This change also includes a refactoring where the action is now avoiding multiple parsing/stringifying of the sarif files. Instead, sarif is parsed once at the start of the process and stringified once, after sarif processing is completely finished.
A single SARIF file should be allowed to have duplicated categories.
Update warning about interpreted languages to mention Ruby
Change category uniqueness test
Bump CodeQL version to 2.7.5
CHANGELOG.md
Outdated
@@ -1,9 +1,14 @@ | |||
# CodeQL Action and CodeQL Runner Changelog | |||
|
|||
## 1.0.28 - 18 Jan 2022 | |||
|
|||
No user facing changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right. Shouldn't the version bump to 2.7.5 be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I also need to add a note about #872
It's been 25 hours since the bundle bump was merged, and I haven't noticed any screaming, so 👍 |
CHANGELOG.md
Outdated
## 1.0.27 - 11 Jan 2022 | ||
|
||
- The `analyze` and `upload-sarif` actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the `wait-for-processing` action input to `"false"`. | ||
|
||
- Update default CodeQL bundle version to 2.7.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this got mismerged into the wrong section of the changelog when I updated my PR.
IIUC the right procedure is to fix it in this PR and then a mergeback PR will be autogenerated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also need to add a change log entry for another feature. So please don't merge until my change is in as well.
Add an entry and move an entry.
53a2f66
to
19970ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
Merging b31df3f into v1
Conductor for this PR is @aeisenberg
Contains the following pull requests:
Please review the following: