Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure loadApiError is caught #882

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Ensure loadApiError is caught #882

merged 5 commits into from
Jan 24, 2022

Commits on Jan 21, 2022

  1. Ensure loadApiError is caught

    And add a better error message.
    
    By using `void` instead of `await`, any error thrown is not caught
    by surrounding try-catch blocks.
    
    I could continue to use `void` and explicitly handle any thrown errors
    by using `.catch`, but most likely the time savings is minimal and
    this makes the code more complex.
    aeisenberg committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    752ae57 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    aeisenberg committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    e175dea View commit details
    Browse the repository at this point in the history
  3. Update error message and remove feature flag preloading

    Discussion here #882 (comment)
    shows that properly handling preloading feature flag errors is complex
    and the benefit we get from it does not offset the complexity.
    aeisenberg committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f18151c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Configuration menu
    Copy the full SHA
    ba352d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    806fc12 View commit details
    Browse the repository at this point in the history