Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI jobs that broke as a result of windows-latest being upgraded to Windows Server 2022 #917

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Feb 8, 2022

windows-latest is currently migrating from an image based on Windows Server 2019 to an image based on Windows Server 2022. This breaks some of our CI jobs for two reasons:

  1. Build tracing doesn't yet support Windows Server 2022
  2. Python 2 isn't supported in the windows-2022 image.

This PR addresses (1) by moving relevant jobs to use the windows-2019 image and (2) by fixing a typo that prevented setup-python from downloading and installing Python 2 when it's not already in the Actions VM image.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer force-pushed the henrymercer/fix-windows-latest-ci-jobs branch 2 times, most recently from d64e51d to d1dd1ff Compare February 8, 2022 11:55
@henrymercer henrymercer marked this pull request as ready for review February 8, 2022 12:56
@henrymercer henrymercer requested a review from a team as a code owner February 8, 2022 12:56
@henrymercer
Copy link
Contributor Author

@github/codeql-action-reviewers Since this PR changes a few jobs from windows-latest to windows-2019, we'll need to modify the required checks before we merge this.

Build tracing currently does not support Windows 2022, so use
`windows-2019` instead of`windows-latest`.
@henrymercer henrymercer force-pushed the henrymercer/fix-windows-latest-ci-jobs branch from e43cec9 to 2ebc770 Compare February 8, 2022 13:31
@henrymercer henrymercer force-pushed the henrymercer/fix-windows-latest-ci-jobs branch from 2ebc770 to 8dd2b9a Compare February 8, 2022 13:50
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably affect some customers who are on windows-latest. We should probably add a change log entry for this. Or maybe even in the readme.

Yeah...this line needs to change, or at least add a caveat:

# CodeQL runs on ubuntu-latest, windows-latest, and macos-latest

@henrymercer
Copy link
Contributor Author

I thought we'd already done a changelog note for Windows Server 2022, but seemingly we only did one for the CLI. I agree we should do a changelog and update the readme, but I suggest we do so in a separate PR so we can get the checks fixed on main and unblock other PRs.

@henrymercer henrymercer changed the title Fix some CI jobs that broke as a result of windows-latest being upgraded to Windows Server 2022 Fix CI jobs that broke as a result of windows-latest being upgraded to Windows Server 2022 Feb 8, 2022
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine by me. A changelog note as well as making a note in the README in a separate PR. Thanks for getting this done.

@henrymercer henrymercer merged commit a777a98 into main Feb 8, 2022
@henrymercer henrymercer deleted the henrymercer/fix-windows-latest-ci-jobs branch February 8, 2022 17:05
@henrymercer
Copy link
Contributor Author

Required checks updated.

@github-actions github-actions bot mentioned this pull request Feb 11, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants