Skip to content

Commit

Permalink
Cleanup from review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
JLLeitschuh committed Feb 15, 2022
1 parent f55ef0e commit 2896c0c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions java/ql/lib/semmle/code/java/frameworks/apache/Lang.qll
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ private class ApacheStrBuilderFluentMethod extends FluentMethod {
}

/**
* The class ``org.apache.commons.lang.SystemUtils` or `org.apache.commons.lang3.SystemUtils`.
* The class `org.apache.commons.lang.SystemUtils` or `org.apache.commons.lang3.SystemUtils`.
*/
class ApacheSystemUtilis extends Class {
ApacheSystemUtilis() {
class ApacheSystemUtils extends Class {
ApacheSystemUtils() {
this.hasQualifiedName(["org.apache.commons.lang", "org.apache.commons.lang3"], "SystemUtils")
}
}
8 changes: 4 additions & 4 deletions java/ql/lib/semmle/code/java/os/OSCheck.qll
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ private import semmle.code.java.dataflow.DataFlow
private import semmle.code.java.StringCheck

/**
* A complimentatry guard that checks if the current platform is Windows.
* A guard that checks if the current platform is Windows.
*/
abstract class IsWindowsGuard extends Guard { }

/**
* A complimentatry guard that checks if the current platform is unix or unix-like.
* A guard that checks if the current platform is unix or unix-like.
*/
abstract class IsUnixGuard extends Guard { }

Expand Down Expand Up @@ -53,7 +53,7 @@ private class IsUnixFromSystemProp extends IsUnixGuard instanceof MethodAccess {

private predicate isOsFromApacheCommons(FieldAccess fa, string fieldName) {
exists(Field f | f = fa.getField() |
f.getDeclaringType() instanceof ApacheSystemUtilis and
f.getDeclaringType() instanceof ApacheSystemUtils and
f.hasName(fieldName)
)
}
Expand All @@ -63,7 +63,7 @@ private class IsWindowsFromApacheCommons extends IsWindowsGuard instanceof Field
}

private class IsUnixFromApacheCommons extends IsUnixGuard instanceof FieldAccess {
IsUnixFromApacheCommons() { isOsFromApacheCommons(this, ["IS_OS_UNIX"]) }
IsUnixFromApacheCommons() { isOsFromApacheCommons(this, "IS_OS_UNIX") }
}

/**
Expand Down

0 comments on commit 2896c0c

Please sign in to comment.