Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - false positive top-level "for await" syntax error [JS] #9957

Closed
leibale opened this issue Aug 2, 2022 · 1 comment · Fixed by #10017
Closed

LGTM.com - false positive top-level "for await" syntax error [JS] #9957

leibale opened this issue Aug 2, 2022 · 1 comment · Fixed by #10017
Assignees
@erik-krogh
Labels
acknowledged GitHub staff acknowledges this issue bug Something isn't working JS

Comments

@leibale
Copy link

leibale commented Aug 2, 2022 •
edited
Loading

Description of the false positive

"Syntax error" for top-level "for await". "normal" top-level await works as expected.

https://lgtm.com/projects/g/redis/node-redis/snapshot/ae44ac1e1a95ebddbba290195fee840d57b04911/files/examples/set-scan.js?sort=name&dir=ASC&mode=heatmap#xf9cc4b8fc3a288c5:1
@hmakholm hmakholm added the JS label Aug 3, 2022
@hmakholm
Copy link
Contributor

hmakholm commented Aug 3, 2022

Thanks for the report. It looks like a parser bug. We'll take a look.

@hmakholm hmakholm added bug Something isn't working acknowledged GitHub staff acknowledges this issue and removed false-positive labels Aug 3, 2022
@simonprickett simonprickett mentioned this issue Aug 4, 2022
Merged
@erik-krogh erik-krogh self-assigned this Aug 11, 2022
@erik-krogh erik-krogh mentioned this issue Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erik-krogh erik-krogh

Labels
acknowledged GitHub staff acknowledges this issue bug Something isn't working JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JS: support top-level for await statements erik-krogh/ql
3 participants
@leibale @hmakholm @erik-krogh