-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates examples. #2219
Updates examples. #2219
Conversation
This pull request introduces 2 alerts when merging 0dc18e0 into 60ad6aa - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #2219 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 430 430
Lines 3968 3968
Branches 448 448
=======================================
Hits 3802 3802
Misses 102 102
Partials 64 64 Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Blocked by github/codeql#9957.
I don't get why it's flagging issues as both example scripts work fine and the $ node set-scan.js
b
j
h
i
q
c
a
l
g
k
d
p
o
m
f
n
e and $ node sorted-set.js
{ value: 'Ninety Nine', score: 99 }
{ value: 'One Hundred', score: 100 }
{ value: 'One Hundred and One', score: 101 } with $ node --version
v16.15.1 |
@simonprickett yea it's a bug in the LGTM parser, I hope it'll get fixed soon, if not I'll merge it anyway |
* Updates examples. * Added command link for hset.
Updates the
examples
folder, moving everything to use top levelawait
, improving command reference links, and fixing a couple of small issues.