Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates examples. #2219

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Updates examples. #2219

merged 3 commits into from
Aug 15, 2022

Conversation

simonprickett
Copy link
Contributor

Updates the examples folder, moving everything to use top level await, improving command reference links, and fixing a couple of small issues.

@simonprickett simonprickett requested a review from leibale August 2, 2022 11:29
@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2022

This pull request introduces 2 alerts when merging 0dc18e0 into 60ad6aa - view on LGTM.com

new alerts:

  • 2 for Syntax error

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #2219 (0dc18e0) into master (60ad6aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2219   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         430      430           
  Lines        3968     3968           
  Branches      448      448           
=======================================
  Hits         3802     3802           
  Misses        102      102           
  Partials       64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Blocked by github/codeql#9957.

@simonprickett
Copy link
Contributor Author

LGTM. Blocked by github/codeql#9957.

I don't get why it's flagging issues as both example scripts work fine and the await in a for loop isn't new code:

$ node set-scan.js
b
j
h
i
q
c
a
l
g
k
d
p
o
m
f
n
e

and

$ node sorted-set.js
{ value: 'Ninety Nine', score: 99 }
{ value: 'One Hundred', score: 100 }
{ value: 'One Hundred and One', score: 101 }

with

$ node --version
v16.15.1

@leibale
Copy link
Contributor

leibale commented Aug 4, 2022

@simonprickett yea it's a bug in the LGTM parser, I hope it'll get fixed soon, if not I'll merge it anyway

@leibale leibale merged commit f3462ab into redis:master Aug 15, 2022
leibale pushed a commit to leibale/node-redis that referenced this pull request Aug 22, 2022
* Updates examples.

* Added command link for hset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants