Remove last updated information and sorting from MRVA views #13821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shati-patel
approved these changes
Jul 26, 2023
shati-patel
added
the
ready-for-doc-review
sabrowning1
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
This looks great, thanks for making these updates @charisk! ✨
The screenshot resolution is perfect 🙂 the one thing I might suggest for the future is taking slightly smaller screenshots, which you can do for bigger UI elements by resizing your window. We don't have any official guidance on screenshot sizing for the CodeQL microsite, but for reference, we aim for less than 1,000 pixels wide on the broader docs site. Definitely not blocking for these updates! 🚀
|
Thank you @sabrowning1 for the review and for the useful and clear guidance! I'll go ahead and merge since it's a bit of a pain getting new screenshots but will take that into account for next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last updated/commit information was removed from MRVA (see github/vscode-codeql#2637) so I'm updating the docs and images to show that.
I'm not sure what requirements there are for images - do I need to make them match the existing ones?