Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Extractor: Remove dependency installation fallback #16127

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Apr 4, 2024

The comments says 2.17.0, but I was a little too late to uphold that promise 😅

@RasmusWL RasmusWL requested a review from a team as a code owner April 4, 2024 14:52
@github-actions github-actions bot added the Python label Apr 4, 2024
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than never! 🙂
(On which note, you may enjoy this shaggy dog story: https://natethesnake.com/)

@RasmusWL RasmusWL merged commit dfe2f1a into github:main Apr 8, 2024
8 checks passed
@RasmusWL RasmusWL deleted the remove-dep-inst-fallback branch April 8, 2024 08:43
RasmusWL added a commit to github/codeql-action that referenced this pull request Apr 8, 2024
See github/codeql#16127 (which will be released
as part of 2.17.1)
tausbn added a commit that referenced this pull request Apr 9, 2024
These failures were likely caused by
#16127

My guess is that they can probably be deleted altogether, but as the
failures are blocking other development, I have opted to simply disable
them for the time being.
RasmusWL added a commit to RasmusWL/codeql that referenced this pull request Apr 9, 2024
Now that we no longer support the fallback option
(github#16127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants