C++: Implement compilation_build_mode

[calumgrant]

Pull Request checklist

All query authors

• [ ] A change note is added if necessary. See the documentation in this repository.
• [ ] All new queries have appropriate .qhelp. See the documentation in this repository.
• QL tests are added if necessary. See Testing custom queries in the GitHub documentation.
• [ ] New and changed queries have correct query metadata. See the documentation in this repository.

Internal query authors only

• [ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
• Changes are validated at scale (internal access required).
• [ ] Adding a new query? Consider also adding the query to autofix.

[jketema]

You should be able to do something like the following (at the very least in a comment). That should give you some identifiers to refer to in the extractor instead of having to hardcoded constants.

case @compilation_build_mode.mode of
  1 = @build_mode_none
| 2 = @build_mode_manual
| 3 = @build_mode_auto
;

[calumgrant]

Done. I did not realise this works in comments as well!

[jketema]

This will need to delete the new table.

[jketema]

Looks like you didn't run the internal workflow we have to generate additional data from out tests.

[calumgrant]

I ran the generate-db-stats workflow, downloaded the artefact, and merge was apparently successful:

[13:53:32] [DCA info] Normalizing stats by user-provided 'exprs'.
[13:53:32] [DCA info] Using stats from tests '~/Downloads/testsuite_stats.xml'.
[13:53:32] [DCA info] Using static stat files from /Users/calum/projects/codeql-dca/static-stats/cpp.

what am I missing?

[jketema]

That's not possible for me to tell from this alone. Let's discuss internally?