-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: Fix jump steps generated by IIFEs and exception flow #18043
Draft
asgerf
wants to merge
19
commits into
github:js/shared-dataflow-branch
Choose a base branch
from
asgerf:jss/jump-and-test-exclusion
base: js/shared-dataflow-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
JS: Fix jump steps generated by IIFEs and exception flow #18043
asgerf
wants to merge
19
commits into
github:js/shared-dataflow-branch
from
asgerf:jss/jump-and-test-exclusion
+387
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generate local flow steps into and out of IIFEs, but these come jump steps automatically, resulting in FPs.
Bailing out can be more expensive as the resulting jump steps themselves cause perf issues. The limit of 100 variables per scope has also been added in the interim, which handles the cases that this needed to cover.
Previously a few Promise-related methods were special-cased, which is no longer needed.
We previously caught this flow because of a heuristic in capture flow. We'll have to fix it properly later.
The VariableCapture library consumes one component of the access path limit, which means we lose this result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues that cause performance (and precision) problems:
js/insecure-randomness
now blocks flow through test cases. Perhaps more queries ought to do this, but it seems particularly problematic for this query. Also broadens our classifications of test files a bit.Evaluation of d1c9e47 looks good:
vscode
, which means it is down to being "only" 79% slower than onmain
(the similar numbers is a coincidence).js/insecure-randomness
Evaluation of d1c9e47 against main shows that we're down to a median 26% slowdown, with a 100% worst-case slowdown.
Evaluation of ce00bd2 vs d1c9e47 is underway