Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: Handle self parameters in variables and SSA library #18088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rust: Handle self parameters in variables and SSA library #18088

wants to merge 1 commit into from
+231 −221

Conversation

paldepind
Copy link
Contributor

Changes in this PR:

  • Handle self parameters as variables.
  • Small refactor.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 25, 2024
@paldepind paldepind mentioned this pull request Nov 25, 2024
Merged
@paldepind paldepind changed the title Rust self parameters Rust: Handle self parameters in variables and SSA library Nov 25, 2024
@paldepind paldepind marked this pull request as ready for review November 25, 2024 18:09
hvitved
hvitved requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you also meant to add a commit for supporting self variables, and not just a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paldepind @hvitved