Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "nearest" behavior for scrollIntoView #79

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Use "nearest" behavior for scrollIntoView #79

merged 1 commit into from
Dec 23, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 23, 2023

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithamus keithamus merged commit ea5e8d6 into github:main Dec 23, 2023
3 checks passed
@keithamus
Copy link
Member

wxiaoguang added a commit to go-gitea/gitea that referenced this pull request Dec 24, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 24, 2023
wxiaoguang added a commit to go-gitea/gitea that referenced this pull request Dec 25, 2023
Backport #28597 by wxiaoguang

Fix #28595 by github/combobox-nav#79 (combobox-nav v2.3.1)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 16, 2024
Backport #28597 by wxiaoguang

Fix #28595 by github/combobox-nav#79 (combobox-nav v2.3.1)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 8a46a64)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The UX is broken with v2.3.0 of @github/combobox-nav dependency
2 participants