Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to auto navigate to the first item on open #81
Add option to auto navigate to the first item on open #81
Changes from 1 commit
c28985b
3995d9d
1ef750e
5f5c1b0
895654a
5c6bd76
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it work to add an
else if (this.firstOptionSelectionMode === 'focused') {this.navigate(1)}
case here instead of defining a separatefocusDefaultOptionIfNeeded
method? That way we only have to call one function instart
and we can't forget to add the second case if we callindicateDefaultOption
elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opt'ed for a new method because this method was also being called here:
combobox-nav/src/index.ts
Line 136 in c28985b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh I see. I think I still would rather combine the methods, but then maybe here we add a conditional
if (this.firstOptionSelectionMode === 'active')
(orif (this.firstOptionSelectionMode !== 'selected')
?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! Addressed here: 1ef750e