Skip to content

Commit

Permalink
Ignore ssh2 native extensions
Browse files Browse the repository at this point in the history
We pull in ssh2 via dockerode:

dockerode
↳ docker-modem
  ↳ ssh2
    ↳ cpu-features

Both it and `cpu-features` compile _optional_ native extensions using
OpenSSH and cpu-features (https://github.com/google/cpu_features) which
result in node-gyp generating two `.node` executables for these bindings

We have found that these bindings are very sensitive to the build env
which means that developer laptops, Actions and Codespaces result in
a diff in the `.node` files, something we seek to prevent in PRs in
order to detect cases where code changes are committed without actually
being applied to the `dist/` folder.

Since we do not actually SSH into any containers in our implementation,
let's just ignore these files in our distributed code rather than
make our build more convoluted/less portable.
  • Loading branch information
brrygrdn committed Feb 15, 2022
1 parent e8734e2 commit 32688a2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ output/output.json
repo
tmp/

# Ignore optional native extensions for SSH
dist/*/build/Release/cpufeatures.node
dist/*/lib/protocol/crypto/build/Release/sshcrypto.node

# Dependency directory
node_modules

Expand Down Expand Up @@ -98,7 +102,3 @@ typings/
# OS metadata
.DS_Store
Thumbs.db

# Ignore built ts files
__tests__/runner/*
lib/**/*

0 comments on commit 32688a2

Please sign in to comment.