-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency and clarity pass on our workflows #76
Conversation
592e8dc
to
0d30c87
Compare
- Use setup-node with .nvmrc in all workflows - Prefer to use checkout with an explicit ref in all workflows - Minor legibility pass on step names/spacing
2c16851
to
4a2bfc7
Compare
4a2bfc7
to
7db94e5
Compare
@@ -19,24 +19,18 @@ jobs: | |||
security-events: write | |||
|
|||
strategy: | |||
fail-fast: false | |||
matrix: | |||
language: [ 'javascript' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually need the matrix:
here, this can just move to line 33, but when I did that in dependabot@3cf6580, it resulted in our continuity of CodeQL Analysis being reset as it essentially saw this as a brand new analysis.
I decided to leave it as it was to avoid any confusion.
- uses: actions/checkout@v2 | ||
- uses: ./ | ||
with: | ||
milliseconds: 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now just lives in check-dist
as it makes sense to do all verification in the 'check the compile' workflow and focus this workflow on developer CI steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
We've had some off and on issues with the check on the
dist/
folder generating different outcomes on people's machines tomain
.While debugging this the fact this check is a quick and dirty
git diff --quiet dist
that just breaks the build without giving output makes it annoying to debug.This branch started out as an attempt to make this friendlier, but I ended up doing a cleanup pass on our workflows addressing the following:
diff
check is now ran as it's own separate workflowdist/
foldernpm
command now usesetup-node
to ensure they use the right version from our.nvmrc
filetest
workflow previously ranprettier
andeslint
using their--fix
style modes, meaning any problems were silently corrected in CI rather than failing the buildnpm run all
command into separate steps so the Action UI does the work of breaking the output up for us ✨dist/
folder for the CodeQL build, so I've slimmed it down to the bare minimum of stepsTODO: