Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.getOctokit #32

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Use github.getOctokit #32

merged 1 commit into from
Oct 26, 2022

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Oct 25, 2022

I think we should use github.getOctokit instead of new Octokit to obtain an Octokit instance that works well with GitHub Enterprise.

See also: https://github.com/actions/toolkit/tree/main/packages/github#readme

@aibaars aibaars marked this pull request as ready for review October 25, 2022 13:23
@aibaars aibaars requested a review from a team as a code owner October 25, 2022 13:23
aibaars added a commit to aibaars/maven-dependency-submission-action that referenced this pull request Oct 25, 2022
This commit includes the changes made in github/dependency-submission-toolkit#32
Copy link
Contributor

@febuiles febuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@febuiles febuiles merged commit 73ab788 into main Oct 26, 2022
@febuiles febuiles deleted the aibaars/get-use-octokit branch October 26, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants