Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node20 support for JavaScript actions #28156

Closed
1 task done
Tracked by #28162
MikeMcC399 opened this issue Sep 12, 2023 · 10 comments
Closed
1 task done
Tracked by #28162

node20 support for JavaScript actions #28156

MikeMcC399 opened this issue Sep 12, 2023 · 10 comments
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@MikeMcC399
Copy link

MikeMcC399 commented Sep 12, 2023

Code of Conduct

What article on docs.github.com is affected?

GitHub Actions > Creating actions > Metadata syntax

What part(s) of the article would you like to see updated?

On the GitHub Actions > Creating actions > Metadata syntax page, the section runs.using for JavaScript actions lists only:

  • Use node16 for Node.js v16.

Node.js 16 however entered end-of-life on Sep 11, 2023 and no newer Node.js version is listed as supported.

Additional information

No response

@MikeMcC399 MikeMcC399 added the content This issue or pull request belongs to the Docs Content team label Sep 12, 2023
@welcome
Copy link

welcome bot commented Sep 12, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 12, 2023
@MikeMcC399
Copy link
Author

MikeMcC399 commented Sep 14, 2023

Can you please also give feedback on which versions of GitHub node20 is already available? I know that it is available on "Free, Pro, & Team" although it is undocumented.

I don't know if it can be expected to be available under Enterprise Cloud, Enterprise Server and GitHub AE.

This is important to know for providers of JavaScript GitHub actions which may be used in different GitHub versions.

@cmwilson21
Copy link
Contributor

Thanks for checking in! I'll surface this again with the team and I'll add this extra note for the team's consideration, as well! 👍

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Sep 14, 2023
@Meroje
Copy link

Meroje commented Sep 15, 2023

Should we expect it to be supported starting from the to-be-announced 3.11 (which could be months from now) or will there be some form of backport to supported Enterprise server version seeing as so much of the ecosystem is jumping on this upgrade ?

@MikeMcC399
Copy link
Author

@Meroje

I guess that you are referring to Enterprise Server 3.11? Are you currently running Enterprise Server 3.10 (or an earlier version) and using self-hosted runners? If so, can you say which version of the GitHub actions/runner/releases you have installed? My understanding is that this gets automatically updated, however I don't have any personal experience of this.

On GitHub-hosted runners the log shows something like this, with a runner version of 2.309.0:

image

@Meroje
Copy link

Meroje commented Sep 19, 2023

On GitHub-hosted runners the log shows something like this, with a runner version of 2.309.0

Thanks for making me check again there was indeed a missed upgrade, node20 is now accepted on our GHES 3.8 / Runner 2.309 stack.

@MikeMcC399
Copy link
Author

@cmwilson21

Thanks for checking in! I'll surface this again with the team and I'll add this extra note for the team's consideration, as well! 👍

Thank you! Can you give any indication about when a change to the documentation for this issue might be published?

@cmwilson21
Copy link
Contributor

@MikeMcC399 I believe this has been merged now so the content should be updated. I'm going to go ahead and close this issue now. Thanks for the follow up! ✨

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Author

@cmwilson21

Please ignore the previous post (which I have hidden as outdated) as the publication has now come through. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

No branches or pull requests

3 participants