Add node20 to runner #2732
Merged
Add node20 to runner #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Sep 5, 2023
xiehan
added a commit
to xiehan/projen-github-action-typescript
that referenced
this pull request
Sep 5, 2023
Node 20 is now supported by the runner (actions/runner#2732) so we should make sure this library supports it as well.
1 task
mergify bot
pushed a commit
to projen/projen-github-action-typescript
that referenced
this pull request
Oct 31, 2023
Node 20 is now supported by the runner (actions/runner#2732) so we should make sure this library supports it as well.
D5688
reviewed
Nov 5, 2023
This was referenced Dec 21, 2023
This was referenced May 2, 2024
Guasonve
reviewed
Jun 28, 2024
| @@ -158,23 +163,29 @@ fi | |||
| # Download the external tools only for OSX. | |||
| if [[ "$PACKAGERUNTIME" == "osx-x64" ]]; then | |||
| acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-x64.tar.gz" node16 fix_nested_dir | |||
| acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-x64.tar.gz" node20 fix_nested_dir | |||
| fi | ||
|
|
||
| if [[ "$PACKAGERUNTIME" == "osx-arm64" ]]; then | ||
| # node.js v12 doesn't support macOS on arm64. | ||
| acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-arm64.tar.gz" node16 fix_nested_dir | ||
| acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-arm64.tar.gz" node20 fix_nested_dir |
| @@ -158,23 +163,29 @@ fi | |||
| # Download the external tools only for OSX. | |||
| if [[ "$PACKAGERUNTIME" == "osx-x64" ]]; then | |||
| acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-x64.tar.gz" node16 fix_nested_dir | |||
| acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-x64.tar.gz" node20 fix_nested_dir | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add node20 to runner
Part of:https://github.com/github/c2c-actions/issues/5943