-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node20 to runner #2732
Merged
Merged
Add node20 to runner #2732
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
07bf080
.
takost b86881a
fix hashes
takost 7d252c9
fix linux-arm
takost a51b756
linux-arm64
takost 28b0e60
osx-x64
takost 3dd6c67
win-x64
takost a9cafd7
clean up node12 deprecation warning
takost 56dcb3a
Merge branch 'main' into takost/add-node-20
takost 74b6351
Add node20
takost 7847f93
Merge branch 'main' into takost/remove-node12
takost eeb4cbc
Remove node12 from the BuildInVersions list
takost f356de0
Merge branch 'takost/remove-node12' into takost/add-node-20
takost 8e8cf29
fix externals hash
takost cfde505
fix externals hash
takost ce967ad
fix externals hash
takost 9671866
fix externals hash
takost 369ec9a
fix externals hash
takost d2ae33a
fix externals hash
takost 965886b
fix externals hash
takost 18339eb
Merge branch 'main' into takost/add-node-20
takost 52a7c3b
update externals hash
takost 18d940c
update externals hash
takost de69061
update externals hash
takost b34bbb6
update externals hash
takost 8bff58a
update externals hash
takost decb396
update externals hash
takost 04f8e91
update externals hash
takost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
209a3b07522d883b745945ec8b1bfa57c0bce769573c3e79206b62959686c0d3 | ||
5bdddd32bab1e57af252b470579083049496e9e39b6e4f50de01232581f9a2d8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1dd7654995ab54ce0d06519ad84c25029f0924f8313f0f5b7811c3631982a5e5 | ||
54b3b3a72da93db0fa38708c759fceadddb70cacdd3620a079084a242126dd78 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
9a06b2be3c18a06d2e676774d8b6d2869854f23f982433e9346bc7bdcb08f362 | ||
e7f2da271abb174285c3a757503538b3e9792e9d731b0382b6d1f21bb59a79ba |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
4eb04e10e173b1f5d7cf8890878a3e178de162e5bf1a583067cf704b8162631a | ||
2481c5b0d06b2b5621635f2568b86a43b0e5b259fed1298167ba4f33d4c464c7 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
fc5efd1df9c75f01d7b6a43018ba49257bdc0d65e743ddd1ae753802a5ddb736 | ||
85de7677165e65ec69b8a9e344c0811efa51b7fe5376a1aa083505c560ea6f57 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
0064acac3fba3bd29851334c90f53adc13f88f2d23f5909f3bbec2b1c4ade9ef | ||
763d18de11c11fd299c0e75e98fefc8a0e6605ae0ad6aba3bbc110db2262ab41 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
e2fa2229ed5bc8857acdd264c2f3964454fd710c776efdfb5dc0b40b7a75065a | ||
16f3cc545dfe10e84df43746073fc64d3c44d1891782532805aeb2118869a55d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ PRECACHE=$2 | |
NODE_URL=https://nodejs.org/dist | ||
UNOFFICIAL_NODE_URL=https://unofficial-builds.nodejs.org/download/release | ||
NODE16_VERSION="16.20.1" | ||
NODE20_VERSION="20.5.0" | ||
# used only for win-arm64, remove node16 unofficial version when official version is available | ||
NODE16_UNOFFICIAL_VERSION="16.20.0" | ||
|
||
|
@@ -140,6 +141,8 @@ function acquireExternalTool() { | |
if [[ "$PACKAGERUNTIME" == "win-x64" || "$PACKAGERUNTIME" == "win-x86" ]]; then | ||
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin | ||
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.lib" node16/bin | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/$PACKAGERUNTIME/node.exe" node20/bin | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/$PACKAGERUNTIME/node.lib" node20/bin | ||
if [[ "$PRECACHE" != "" ]]; then | ||
acquireExternalTool "https://github.com/microsoft/vswhere/releases/download/2.6.7/vswhere.exe" vswhere | ||
fi | ||
|
@@ -150,6 +153,8 @@ if [[ "$PACKAGERUNTIME" == "win-arm64" ]]; then | |
# todo: replace these with official release when available | ||
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_UNOFFICIAL_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin | ||
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_UNOFFICIAL_VERSION}/$PACKAGERUNTIME/node.lib" node16/bin | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/$PACKAGERUNTIME/node.exe" node20/bin | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/$PACKAGERUNTIME/node.lib" node20/bin | ||
if [[ "$PRECACHE" != "" ]]; then | ||
acquireExternalTool "https://github.com/microsoft/vswhere/releases/download/2.6.7/vswhere.exe" vswhere | ||
fi | ||
|
@@ -158,23 +163,29 @@ fi | |
# Download the external tools only for OSX. | ||
if [[ "$PACKAGERUNTIME" == "osx-x64" ]]; then | ||
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-x64.tar.gz" node16 fix_nested_dir | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-x64.tar.gz" node20 fix_nested_dir | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Vgf |
||
fi | ||
|
||
if [[ "$PACKAGERUNTIME" == "osx-arm64" ]]; then | ||
# node.js v12 doesn't support macOS on arm64. | ||
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-darwin-arm64.tar.gz" node16 fix_nested_dir | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-darwin-arm64.tar.gz" node20 fix_nested_dir | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pa |
||
fi | ||
|
||
# Download the external tools for Linux PACKAGERUNTIMEs. | ||
if [[ "$PACKAGERUNTIME" == "linux-x64" ]]; then | ||
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-linux-x64.tar.gz" node16 fix_nested_dir | ||
acquireExternalTool "https://vstsagenttools.blob.core.windows.net/tools/nodejs/${NODE16_VERSION}/alpine/x64/node-v${NODE16_VERSION}-alpine-x64.tar.gz" node16_alpine | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-linux-x64.tar.gz" node20 fix_nested_dir | ||
acquireExternalTool "https://vstsagenttools.blob.core.windows.net/tools/nodejs/${NODE20_VERSION}/alpine/x64/node-v${NODE20_VERSION}-alpine-x64.tar.gz" node20_alpine | ||
fi | ||
|
||
if [[ "$PACKAGERUNTIME" == "linux-arm64" ]]; then | ||
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-linux-arm64.tar.gz" node16 fix_nested_dir | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-linux-arm64.tar.gz" node20 fix_nested_dir | ||
fi | ||
|
||
if [[ "$PACKAGERUNTIME" == "linux-arm" ]]; then | ||
acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-linux-armv7l.tar.gz" node16 fix_nested_dir | ||
acquireExternalTool "$NODE_URL/v${NODE20_VERSION}/node-v${NODE20_VERSION}-linux-armv7l.tar.gz" node20 fix_nested_dir | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: 'Hello World' | ||
description: 'Greet the world and record the time' | ||
author: 'Test Corporation' | ||
inputs: | ||
greeting: # id of input | ||
description: 'The greeting we choose - will print ""{greeting}, World!"" on stdout' | ||
required: true | ||
default: 'Hello' | ||
deprecationMessage: 'This property has been deprecated' | ||
entryPoint: # id of input | ||
description: 'optional docker entrypoint overwrite.' | ||
required: false | ||
outputs: | ||
time: # id of output | ||
description: 'The time we did the greeting' | ||
icon: 'hello.svg' # vector art to display in the GitHub Marketplace | ||
color: 'green' # optional, decorates the entry in the GitHub Marketplace | ||
runs: | ||
using: 'node20' | ||
main: 'main.js' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mio