Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use node20 and upgrade ncc #55

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: use node20 and upgrade ncc #55

merged 1 commit into from
Nov 8, 2023

Conversation

chenrui333
Copy link
Contributor

This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)


Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0.
Node16 has en end of life on 11 Sep 2023.

This PR updates the default runtime to node20, rather then node16

relates to actions/runner#2732

Signed-off-by: Rui Chen <rui@chenrui.dev>
@timheuer
Copy link
Owner

timheuer commented Nov 8, 2023

Thanks @chenrui333 -- I'll take a look and hopefully merge this today.

@timheuer
Copy link
Owner

timheuer commented Nov 8, 2023

@all-contributors please add @chenrui333 for Code

Copy link
Contributor

@timheuer

I've put up a pull request to add @chenrui333! 🎉

@timheuer timheuer merged commit 940b03f into timheuer:main Nov 8, 2023
1 check passed
@chenrui333
Copy link
Contributor Author

@timheuer you would also need a major version release per this change. (forgot to specify in the PR desc), and thanks for the merge! 🎉

@timheuer
Copy link
Owner

timheuer commented Nov 9, 2023

@timheuer you would also need a major version release per this change. (forgot to specify in the PR desc), and thanks for the merge! 🎉

What do you mean here? I've updated the v1, v1.2 tags to this commit.

@chenrui333
Copy link
Contributor Author

@timheuer you would also need a major version release per this change. (forgot to specify in the PR desc), and thanks for the merge! 🎉

What do you mean here? I've updated the v1, v1.2 tags to this commit.

yeah, should be a major version bump in terms of release semantics (also aligns with the github setup-* actions)

@timheuer
Copy link
Owner

timheuer commented Nov 9, 2023

Got it. In this case, I've not treated these updates as such and ensured minor/revision are updated and tags as well. There isn't any major functionality change here (none in fact) and it is more clearing the warnings that would happen.

@chenrui333
Copy link
Contributor Author

chenrui333 commented Nov 15, 2023

Got it. In this case, I've not treated these updates as such and ensured minor/revision are updated and tags as well. There isn't any major functionality change here (none in fact) and it is more clearing the warnings that would happen.

this is mostly tied with how we interpret the release semantics, in terms of the action itself, yeah, I agree, there is no function change, but in terms of dependant runtime, there is a big reference (because the nature of the action runtime tied with the runner I do feel like it would be nice to make it a major release)

Sometimes people are actually using appVersion-runtimeVersion (like jdk-scala), which I feel a bit too much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants