Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikis can now be indexed by search engines. #10836

Closed
wants to merge 6 commits into from
Closed

Wikis can now be indexed by search engines. #10836

wants to merge 6 commits into from

Conversation

nelsonjchen
Copy link
Contributor

@nelsonjchen nelsonjchen commented Oct 7, 2021 •
edited
Loading

Why:

community/community#4992 (comment)

https://github.com/robots.txt no longer contains an entry preventing crawlers from crawling GitHub Wikis. Compare to this snapshot from Internet Archive: https://web.archive.org/web/20210403000950/github.com/robots.txt

What's being changed:

Remove no longer accurate statement that came from #5054.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 7, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 7, 2021
@ramyaparimi
Copy link
Contributor

@nelsonjchen
Thanks so much for opening a PR! I'll get this triaged for review ⚡

lecoursen
lecoursen approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll get this merged ASAP.

@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Oct 7, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Oct 7, 2021
@nelsonjchen
Copy link
Contributor Author

nelsonjchen commented Oct 8, 2021 •
edited
Loading

Oof, I need to abort this PR: community/community#4992 (comment)

I didn't know you could block robots with headers.

edit: though i guessed you could, but it wasn't obvious that they replaced the mechanism with this method.

@nelsonjchen nelsonjchen closed this Oct 8, 2021
auto-merge was automatically disabled October 8, 2021 14:15

Pull request was closed

@nelsonjchen
Copy link
Contributor Author

Though, thanks for reviewing the change anyway docs team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nelsonjchen @ramyaparimi @lecoursen @janiceilene