Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what happens with git remote rm command #13826

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

peterjv26
Copy link
Contributor

Added a note to say the "git remote rm" command just unlinks local and remote repositories

Why:

Closes [issue link]

What's being changed:

Updated the doc adding a line to clarify what exactly happens with "git remove rm" command

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Added a note to say this just unlinks local and remote repositories
@welcome
Copy link

welcome bot commented Jan 8, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/get-started/getting-started-with-git/managing-remote-repositories.md Modified Original

@github-actions github-actions bot temporarily deployed to docs-13826--patch-2 January 8, 2022 08:01 Inactive
@ramyaparimi ramyaparimi added invalid This issue/PR is invalid and removed invalid This issue/PR is invalid labels Jan 10, 2022
@github-actions github-actions bot closed this Jan 10, 2022
@ramyaparimi ramyaparimi reopened this Jan 10, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Jan 10, 2022
@ramyaparimi
Copy link
Contributor

@peterjv26
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@github-actions github-actions bot temporarily deployed to docs-13826--patch-2 January 10, 2022 13:16 Inactive
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition! I made some minor wording changes that I will incorporate, then we'll get this merged down for you.

@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 10, 2022
@github-actions github-actions bot temporarily deployed to docs-13826--patch-2 February 10, 2022 00:14 Inactive
@github-actions github-actions bot temporarily deployed to docs-13826--patch-2 February 10, 2022 14:17 Inactive
@ramyaparimi ramyaparimi merged commit 6c5d0a5 into github:main Feb 10, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants