Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary use of range of days #15305

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Conversation

lifton
Copy link
Contributor

@lifton lifton commented Feb 9, 2022

When defining an expected response time to a request, use a single number, not a range of numbers.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

When defining an expected response time to a request, use a single number, not a range of numbers.
@welcome
Copy link

welcome bot commented Feb 9, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 9, 2022
@github-actions github-actions bot temporarily deployed to docs-15305--patch-2 February 9, 2022 21:05 Inactive
@lifton
Copy link
Contributor Author

lifton commented Feb 9, 2022

I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).

I couldn't find this, so I can't confirm what it looks like on staging. Can someone provide a link?

Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lifton Thanks so much for opening a PR with this fix! I'll get this merged once tests are passing 🍏

@ramyaparimi
Copy link
Contributor

ramyaparimi commented Feb 10, 2022

@lifton

I couldn't find this, so I can't confirm what it looks like on staging. Can someone provide a link?

If the comment with staging links isn't posted, you will still be able to view your deployment by clicking on show environments in the PR timeline ✨
image

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Feb 10, 2022
@github-actions github-actions bot temporarily deployed to docs-15305--patch-2 February 10, 2022 13:44 Inactive
@ramyaparimi ramyaparimi merged commit d08235b into github:main Feb 10, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@lifton lifton deleted the patch-2 branch February 10, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants