Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPG auto-sign commands #21497

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Conversation

sih4sing5hong5
Copy link
Contributor

@sih4sing5hong5 sih4sing5hong5 commented Oct 20, 2022

Why:

Add automatic signing commands in docs.

Relative issues:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Thank for amazing preview

This commands is in sixth steps:

screen shot

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Oct 20, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@sih4sing5hong5
Copy link
Contributor Author

It seems Link Checker was broken.

Run node .github/actions/rendered-content-link-checker.js
  node .github/actions/rendered-content-link-checker.js
  shell: /usr/bin/bash -e {0}
  env:
    LEVEL: critical
    ACTION_RUN_URL: https://github.com/github/docs/actions/runs/3286389283
    GITHUB_TOKEN: 
    SHOULD_COMMENT: true
    CHECK_EXTERNAL_LINKS: false
    CREATE_REPORT: false
file:///home/runner/work/docs/docs/.github/actions/lib/get-env-inputs.js:13
        throw new Error(`You must supply a ${envVarName} environment variable`)
              ^

Error: You must supply a GITHUB_TOKEN environment variable
    at file:///home/runner/work/docs/docs/.github/actions/lib/get-env-inputs.js:13:15
    at Array.map (<anonymous>)
    at getEnvInputs (file:///home/runner/work/docs/docs/.github/actions/lib/get-env-inputs.js:10:13)
    at file:///home/runner/work/docs/docs/.github/actions/rendered-content-link-checker.js:55:3
Error: Process completed with exit code 1.

@sih4sing5hong5 sih4sing5hong5 marked this pull request as ready for review October 20, 2022 02:58
@cmwilson21
Copy link
Contributor

@sih4sing5hong5 Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Oct 20, 2022
Copy link
Contributor

@isaacmbrown isaacmbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sih4sing5hong5, thanks for raising the PR ✨ This looks like a worthwhile addition. Have just added a little bit of information to the step to add some clarity 🙂

@isaacmbrown isaacmbrown added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 21, 2022
@cmwilson21 cmwilson21 merged commit 2d0df88 into github:main Oct 21, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@cmwilson21 cmwilson21 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 21, 2022
@sih4sing5hong5
Copy link
Contributor Author

Hi @sih4sing5hong5, thanks for raising the PR sparkles This looks like a worthwhile addition. Have just added a little bit of information to the step to add some clarity slightly_smiling_face

@isaacmbrown Thanks. It's more user-friendly!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants