-
Notifications
You must be signed in to change notification settings - Fork 59.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installing-the-github-copilot-extension-in-your-environment.md #33955
Conversation
Switched the Neovim and Vim install instructions around. This is as: - If someone was installing copilot on Neovim, they would reasonably come across the vim section, follow the instructions and then realise, as they scroll down, they did it incorrectly, - On the other hand, if someone was installing it on vim, they would be much less likely to read the Neovim part and believe it was for them. To further emphasise the difference between the sections, as they are hard to tell apart, I put vim and neovim in italics in the subheadings.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@sammyhori Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sammyhori 👋 thank you for taking the time to contribute to our docs, we really appreciate it. The combination of italics and bold goes against our style guide, so I've removed that, but I'll move forward with the reordering as you suggested. Thank you again ✨
...t/configure-personal-settings/installing-the-github-copilot-extension-in-your-environment.md
Outdated
Show resolved
Hide resolved
...t/configure-personal-settings/installing-the-github-copilot-extension-in-your-environment.md
Outdated
Show resolved
Hide resolved
...t/configure-personal-settings/installing-the-github-copilot-extension-in-your-environment.md
Outdated
Show resolved
Hide resolved
...t/configure-personal-settings/installing-the-github-copilot-extension-in-your-environment.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Also, the two sections are very difficult to tell apart when you first come across them, due to the differences in them being minor.
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Switched the Neovim and Vim install instructions around.
To further emphasise the difference between the sections, I put vim and neovim in italics in the subheadings.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.