Skip to content

Commit

Permalink
Merge pull request #395 from github/kh-bump-eslint-dependency
Browse files Browse the repository at this point in the history
Bump eslint-plugin-jsx-a11y to 6.7.1
  • Loading branch information
khiga8 committed Feb 6, 2023
2 parents 11b66bf + 019e11e commit 759a37b
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 6 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,4 @@ This config will be interpreted in the following way:

#### Accessibility-focused rules (prefixed with a11y)

- [No Generic Link Text](./docs/rules/a11y-no-generic-link-text.md)
- [Role Supports ARIA Props](./docs/rules/role-supports-aria-props.md)
4 changes: 3 additions & 1 deletion docs/rules/a11y-no-generic-link-text.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# No Generic Link Text
# No Generic Link Text [Deprecated]

_This rule has been deprecated in favor of `anchor-ambiguous-text` in `eslint-plugin-jsx-a11y`._

## Rule Details

Expand Down
10 changes: 8 additions & 2 deletions lib/configs/react.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@ module.exports = {
plugins: ['github', 'jsx-a11y'],
extends: ['plugin:jsx-a11y/recommended'],
rules: {
'github/a11y-no-generic-link-text': 'error',
'jsx-a11y/role-supports-aria-props': 'off', // Override with github/role-supports-aria-props until https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/910 is resolved
'github/role-supports-aria-props': 'error',
'jsx-a11y/role-supports-aria-props': 'off',
'jsx-a11y/no-aria-hidden-on-focusable': 'error',
'jsx-a11y/anchor-ambiguous-text': [
'error',
{
words: ['this', 'more', 'read here', 'read more'],
},
],
},
}
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"eslint-plugin-filenames": "^1.3.2",
"eslint-plugin-i18n-text": "^1.0.1",
"eslint-plugin-import": "^2.25.2",
"eslint-plugin-jsx-a11y": "^6.6.0",
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-no-only-tests": "^3.0.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint-rule-documentation": ">=1.0.0",
Expand Down

0 comments on commit 759a37b

Please sign in to comment.