Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort-imports
seems to have a pretty inscrutable algorithm for how it sorts. It's not based on the import specifier, and seems to be based on bindings.We see a lot of complaints about this rule:
We added
sort-imports
in https://github.com/github/github/pull/51096 with a slew of other changes around import rules to catch bugs. Howeversort-imports
didn't have good justification in isolation. Given the lack of justification originally, and given the amount of pain it causes today, I think it's a good idea to simply remove this rule.