-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aria-query and update to fix tests #448
Changes from 8 commits
951feea
95c60cf
762f7e1
2747f2d
d21a25e
281fa95
33fe0b0
985fa01
247eea2
5c98a44
ba52aca
b12cda5
9136431
2fa5eca
b2ed30e
8fb6419
5a66033
aaca700
40c0b2b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,9 +57,6 @@ ruleTester.run('role-supports-aria-props', rule, { | |
{code: '<a href="#" aria-owns />'}, | ||
{code: '<a href="#" aria-relevant />'}, | ||
|
||
// this will have global | ||
{code: '<a aria-checked />'}, | ||
Comment on lines
-60
to
-61
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is now treated as |
||
|
||
// AREA TESTS - implicit role is `link` | ||
{code: '<area href="#" aria-expanded />'}, | ||
{code: '<area href="#" aria-atomic />'}, | ||
|
@@ -78,30 +75,6 @@ ruleTester.run('role-supports-aria-props', rule, { | |
{code: '<area href="#" aria-owns />'}, | ||
{code: '<area href="#" aria-relevant />'}, | ||
|
||
// this will have global | ||
{code: '<area aria-checked />'}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is now treated as |
||
|
||
// LINK TESTS - implicit role is `link` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
{code: '<link href="#" aria-expanded />'}, | ||
{code: '<link href="#" aria-atomic />'}, | ||
{code: '<link href="#" aria-busy />'}, | ||
{code: '<link href="#" aria-controls />'}, | ||
{code: '<link href="#" aria-describedby />'}, | ||
{code: '<link href="#" aria-disabled />'}, | ||
{code: '<link href="#" aria-dropeffect />'}, | ||
{code: '<link href="#" aria-flowto />'}, | ||
{code: '<link href="#" aria-grabbed />'}, | ||
{code: '<link href="#" aria-hidden />'}, | ||
{code: '<link href="#" aria-haspopup />'}, | ||
{code: '<link href="#" aria-label />'}, | ||
{code: '<link href="#" aria-labelledby />'}, | ||
{code: '<link href="#" aria-live />'}, | ||
{code: '<link href="#" aria-owns />'}, | ||
{code: '<link href="#" aria-relevant />'}, | ||
|
||
// this will have global | ||
{code: '<link aria-checked />'}, | ||
|
||
// this will have role of `img` | ||
{code: '<img alt="foobar" aria-busy />'}, | ||
|
||
|
@@ -344,20 +317,25 @@ ruleTester.run('role-supports-aria-props', rule, { | |
{code: '<datalist aria-expanded />'}, | ||
{code: '<div role="heading" aria-level />'}, | ||
{code: '<div role="heading" aria-level="1" />'}, | ||
{code: '<link href="#" aria-expanded />'}, // link maps to nothing | ||
], | ||
|
||
invalid: [ | ||
// implicit basic checks | ||
{ | ||
code: '<a href="#" aria-checked />', | ||
errors: [getErrorMessage('aria-checked', 'link')], | ||
code: '<area aria-checked />', | ||
errors: [getErrorMessage('aria-checked', 'generic')], | ||
}, | ||
{ | ||
code: '<area href="#" aria-checked />', | ||
code: '<a aria-checked />', | ||
errors: [getErrorMessage('aria-checked', 'generic')], | ||
}, | ||
{ | ||
code: '<a href="#" aria-checked />', | ||
errors: [getErrorMessage('aria-checked', 'link')], | ||
}, | ||
{ | ||
code: '<link href="#" aria-checked />', | ||
code: '<area href="#" aria-checked />', | ||
errors: [getErrorMessage('aria-checked', 'link')], | ||
}, | ||
{ | ||
|
@@ -370,7 +348,7 @@ ruleTester.run('role-supports-aria-props', rule, { | |
}, | ||
{ | ||
code: '<aside aria-checked />', | ||
errors: [getErrorMessage('aria-checked', 'complementary')], | ||
errors: [getErrorMessage('aria-checked', 'generic')], | ||
}, | ||
{ | ||
code: '<ul aria-expanded />', | ||
|
@@ -386,15 +364,15 @@ ruleTester.run('role-supports-aria-props', rule, { | |
}, | ||
{ | ||
code: '<aside aria-expanded />', | ||
errors: [getErrorMessage('aria-expanded', 'complementary')], | ||
errors: [getErrorMessage('aria-expanded', 'generic')], | ||
}, | ||
{ | ||
code: '<article aria-expanded />', | ||
errors: [getErrorMessage('aria-expanded', 'article')], | ||
}, | ||
{ | ||
code: '<body aria-expanded />', | ||
errors: [getErrorMessage('aria-expanded', 'document')], | ||
errors: [getErrorMessage('aria-expanded', 'generic')], | ||
}, | ||
{ | ||
code: '<li aria-expanded />', | ||
|
@@ -414,6 +392,10 @@ ruleTester.run('role-supports-aria-props', rule, { | |
}, | ||
{ | ||
code: '<section aria-expanded />', | ||
errors: [getErrorMessage('aria-expanded', 'generic')], | ||
}, | ||
{ | ||
code: '<section aria-label="something" aria-expanded />', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If |
||
errors: [getErrorMessage('aria-expanded', 'region')], | ||
}, | ||
{ | ||
|
@@ -480,10 +462,6 @@ ruleTester.run('role-supports-aria-props', rule, { | |
code: '<menu type="toolbar" aria-expanded />', | ||
errors: [getErrorMessage('aria-expanded', 'toolbar')], | ||
}, | ||
{ | ||
code: '<link href="#" aria-invalid />', | ||
errors: [getErrorMessage('aria-invalid', 'link')], | ||
}, | ||
{ | ||
code: '<area href="#" aria-invalid />', | ||
errors: [getErrorMessage('aria-invalid', 'link')], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this doesn't consider ALL constraints, but I think it's fine for now since it will cover most cases we're concerned about (e.g.
<span aria-label>
.Whatever isn't matched should be skipped and we should avoid raising false positives.