Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github app authentication and repo standardization #79

Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Mar 30, 2024

Closes #48

Pull Request

Proposed Changes

  • update README with new env vars
  • standardize workflows and examples to contents: read permission defaults
  • linting setup for Makefile
  • requirements-test.txt for testing dependencies
  • update super-linter to v6

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@jmeridth jmeridth added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 30, 2024
@jmeridth jmeridth self-assigned this Mar 30, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner March 30, 2024 04:31
- [x] update README with new env vars
- [x] standardize workflows and examples to contents: read permission
  defaults
- [x] linting setup for Makefile
- [x] requirements-test.txt for testing dependencies

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth force-pushed the jm-github-app-auth-repo-standardization branch from 48d516e to 3ec7408 Compare March 30, 2024 04:34
@jmeridth
Copy link
Member Author

Got linting right the first time. Miracles do happen.

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmeridth jmeridth merged commit a7ecef4 into github:main Apr 1, 2024
4 checks passed
@jmeridth jmeridth deleted the jm-github-app-auth-repo-standardization branch April 1, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants