Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate error messages with newline #18

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Terminate error messages with newline #18

merged 1 commit into from
Dec 1, 2022

Conversation

ethanis
Copy link
Member

@ethanis ethanis commented Nov 30, 2022

What's changing?

This ensures that error messages get terminated with a newline character.

How's this tested?

$ docker images rm ghcr.io/actions-importer/cli
$ dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- audit jenkins -o output

Closes #16

@ethanis ethanis requested a review from a team as a code owner November 30, 2022 17:20
@github-actions
Copy link

Unit Test Results

38 tests  ±0   38 ✔️ ±0   0s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c68acf2. ± Comparison against base commit ad7df31.

@ethanis ethanis merged commit 03be315 into main Dec 1, 2022
@ethanis ethanis deleted the error-message-newline branch December 1, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaguereca begonaguereca begonaguereca approved these changes

@j-dunham j-dunham Awaiting requested review from j-dunham j-dunham was automatically assigned from github/actions-importer-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Support]: no newline included at end of failure output
2 participants
@ethanis @begonaguereca