-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multipart uploads updated logic #1285
Merged
begonaguereca
merged 30 commits into
git-storage-option-feature
from
git-storage-multi-part
Oct 30, 2024
Merged
Multipart uploads updated logic #1285
begonaguereca
merged 30 commits into
git-storage-option-feature
from
git-storage-multi-part
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begonaguereca
changed the title
GSM multipart uploads updated logic
Multipart uploads updated logic
Oct 24, 2024
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
begonaguereca
changed the base branch from
git-storage-option-feature
to
main
October 29, 2024 19:26
begonaguereca
changed the base branch from
main
to
git-storage-option-feature
October 29, 2024 19:50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so much better now, my main concerns were mostly around testing this time.
src/OctoshiftCLI.Tests/Octoshift/Services/ArchiveUploadersTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
ArinGhazarian
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 🎉 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.ghe.com/github/octoshift/issues/9496!
Closes https://github.ghe.com/github/octoshift/issues/9535!
ThirdPartyNotices.txt
(if applicable)Take it out for a 🚗 :
*** Remember to export env variables***
Migrating from GitHub Enterprise Server- Multi part upload:
Sample repo to export: https://octoshift-ghe.westus2.cloudapp.azure.com/github-owned-storage/1-gib
Successful migration_id: RM_kgDaACQ0MzZmN2RjMS0wNjk4LTRlYjctYmMzNy0wMTAxNGRhOTQ3YTU