Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart uploads updated logic #1285

Merged
merged 30 commits into from
Oct 30, 2024

Conversation

begonaguereca
Copy link
Collaborator

@begonaguereca begonaguereca commented Oct 22, 2024

Closes https://github.ghe.com/github/octoshift/issues/9496!
Closes https://github.ghe.com/github/octoshift/issues/9535!

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Take it out for a 🚗 :

*** Remember to export env variables***

export GH_SOURCE_PAT=<<PAT>>
export GH_PAT=<<PAT>> 

Migrating from GitHub Enterprise Server- Multi part upload:

Sample repo to export: https://octoshift-ghe.westus2.cloudapp.azure.com/github-owned-storage/1-gib

dotnet run --project src/gei/gei.csproj -- migrate-repo --github-source-org github-owned-storage --source-repo large-1-gib --github-target-org import-testing --target-repo YOU_ADD_NEW_NAME --use-github-storage true --ghes-api-url https://octoshift-ghe.westus2.cloudapp.azure.com/api/v3 --verbose

Successful migration_id: RM_kgDaACQ0MzZmN2RjMS0wNjk4LTRlYjctYmMzNy0wMTAxNGRhOTQ3YTU

src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubClient.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubClient.cs Outdated Show resolved Hide resolved
@begonaguereca begonaguereca changed the title GSM multipart uploads updated logic Multipart uploads updated logic Oct 24, 2024
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
begonaguereca and others added 4 commits October 25, 2024 14:06
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
@begonaguereca begonaguereca marked this pull request as ready for review October 25, 2024 22:52
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/MultipartUploaderService.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/GithubApi.cs Show resolved Hide resolved
src/ado2gh/Factories/GithubApiFactory.cs Show resolved Hide resolved
@begonaguereca begonaguereca changed the base branch from git-storage-option-feature to main October 29, 2024 19:26
@begonaguereca begonaguereca changed the base branch from main to git-storage-option-feature October 29, 2024 19:50
Copy link
Collaborator

@ArinGhazarian ArinGhazarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better now, my main concerns were mostly around testing this time.

src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs Outdated Show resolved Hide resolved
src/OctoshiftCLI.IntegrationTests/GhesToGithub.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/ArchiveUploader.cs Outdated Show resolved Hide resolved
src/Octoshift/Services/ArchiveUploader.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ArinGhazarian ArinGhazarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🎉 🥇

@begonaguereca begonaguereca merged commit 451ed8d into git-storage-option-feature Oct 30, 2024
@begonaguereca begonaguereca deleted the git-storage-multi-part branch October 30, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants