-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBS integration test for multipart uploads with GH owned storage #1299
Conversation
Unit Test Results834 tests 834 ✅ 22s ⏱️ Results for commit db82dd8. ♻️ This comment has been updated with latest results. |
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits but the rest is good 👍
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes https://github.ghe.com/github/octoshift/issues/9670!
We decided that it was critical that we have an integration test that tests the multipart logic of the GitHub owned blob storage.
ThirdPartyNotices.txt
(if applicable)