Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBS integration test for multipart uploads with GH owned storage #1299

Merged
merged 23 commits into from
Nov 19, 2024

Conversation

begonaguereca
Copy link
Collaborator

@begonaguereca begonaguereca commented Nov 18, 2024

Closes https://github.ghe.com/github/octoshift/issues/9670!

We decided that it was critical that we have an integration test that tests the multipart logic of the GitHub owned blob storage.

Screenshot 2024-11-19 at 6 27 23 AM
  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Copy link

github-actions bot commented Nov 18, 2024

Unit Test Results

834 tests   834 ✅  22s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit db82dd8.

♻️ This comment has been updated with latest results.

@begonaguereca begonaguereca marked this pull request as ready for review November 18, 2024 21:26
Copy link
Collaborator

@ArinGhazarian ArinGhazarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits but the rest is good 👍

src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs Outdated Show resolved Hide resolved
src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs Outdated Show resolved Hide resolved
begonaguereca and others added 2 commits November 18, 2024 18:00
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Co-authored-by: Arin Ghazarian <aringhazarian@github.com>
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 80% 72% 554
ado2gh 84% 78% 627
Octoshift 87% 76% 1298
bbs2gh 79% 74% 680
Summary 84% (7039 / 8422) 76% (1597 / 2114) 3159

Copy link

@vanessaperson vanessaperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@begonaguereca begonaguereca merged commit af327dc into main Nov 19, 2024
30 checks passed
@begonaguereca begonaguereca deleted the bbs-multipart branch November 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants