Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback setup-dotnet action #940

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Conversation

dylan-smith
Copy link
Collaborator

@dylan-smith dylan-smith commented Apr 4, 2023

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

When we upgraded the setup-dotnet action from v1 to v3 yesterday it caused our builds to get significantly longer (3.5min -> 8.5 min for one job).

I narrowed it down to something specifically in v3.0.0 of that action. I will open an issue for the team that owns that action to hopefully help us shed some more light on what's going on, in the meantime this PR rolls us back to v2.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Unit Test Results

746 tests   746 ✔️  21s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 40114fc.

♻️ This comment has been updated with latest results.

@dylan-smith dylan-smith marked this pull request as ready for review April 4, 2023 13:04
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
bbs2gh 82% 78% 627
gei 85% 80% 687
Octoshift 87% 73% 1138
ado2gh 84% 81% 653
Summary 85% (6826 / 8041) 77% (1672 / 2158) 3105

@dylan-smith
Copy link
Collaborator Author

Opened this Issue for the folks that own this action to hopefully figure out what's going on: actions/setup-dotnet#410

@dylan-smith dylan-smith enabled auto-merge (squash) April 4, 2023 15:24
@dylan-smith dylan-smith merged commit 5d2a582 into main Apr 4, 2023
@dylan-smith dylan-smith deleted the dylan-smith/rollback-setup-dotnet branch April 4, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants