Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/setup-dotnet from 2 to 3 #949

Merged
merged 6 commits into from
May 13, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 10, 2023

Bumps actions/setup-dotnet from 2 to 3.

Release notes

Sourced from actions/setup-dotnet's releases.

v3.0.0

This major release includes the following changes:

  • #219 New input dotnet-quality was added in #315:
    - uses: actions/setup-dotnet@v3
      with:
        dotnet-version: '6.0.x'
        dotnet-quality: 'preview'
    - run: dotnet build <my project>

More in detail here.

  • #241 The output variable dotnet-version which contains the installed by the action SDK version was added in #324:
    - uses: actions/setup-dotnet@v3
      id: cp310
      with:
        dotnet-version: '3.1.422'
    - run: echo '${{ steps.cp310.outputs.dotnet-version }}' # outputs 3.1.422

More in detail here.

  • The dotnet-version syntax was updated and now it allows to specify the prerelease version without using include-prerelease input. The include-prerelease input was cut out:
    - uses: actions/setup-dotnet@v3
      with:
        dotnet-version: '5.0.0-preview.6'

More in detail here.

  • #251 The problem with out of support .NET version warnings was solved in #315.

Breaking changes:

  • Installation paths for Windows and Ubuntu images were changed to match the location of pre-installed SDKs. In more detail, read here.

Add support for Windows-arm

In scope of this release we add support for Windows-arm. Besides, we change getInput to getBooleanInput for include-prerelease.

Package updates, support for global json file in a subdirectory, installer scripts updates

This release includes the following PRs:

  • Adding support for the global-json-file input: #276 Example of usage:
    - uses: actions/setup-dotnet@v2
      with:
        global-json-file: csharp/global.json
    - run: dotnet build <my project>
      working-directory: csharp

... (truncated)

Commits
  • 607fce5 Update the link to the .Net Core releases index file (#337)
  • 501b34e Merge pull request #336 from e-korolevskii/refactor-nuget-cfg-parse
  • b827fcc build
  • 239baf3 Merge branch 'main' into refactor-nuget-cfg-parse
  • 4d4a70f Add logic for processing DOTNET_INSTALL_DIR environment variable (#332)
  • 70c3f4d Merge pull request #331 from rentziass/rentziass/update-actions-core
  • 9260643 Update @​actions/core to 1.10.0
  • 45c9f23 Enable ability to change .NET SDK installation directory by `DOTNET_INSTALL_D...
  • 6d6c7c9 build
  • e753bbf remove build
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Apr 10, 2023
@github-actions
Copy link

github-actions bot commented Apr 10, 2023

Unit Test Results

751 tests   751 ✔️  23s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit d54f84e.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dylan-smith dylan-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can merge this we need to add a global.json to pin our SDK at v6 for perf reasons, and update the args to setup-dotnet to use the global.json version

Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 2 to 3.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/setup-dotnet-3 branch from 7fbe744 to d54f84e Compare April 11, 2023 21:00
@dylan-smith
Copy link
Collaborator

Before we can merge this we need to add a global.json to pin our SDK at v6 for perf reasons, and update the args to setup-dotnet to use the global.json version

Added a global.json file which will force the dotnet commands to use SDK v6.0.408 (or newer, but only 6.0.x versions). This matches the version that we are having setup-dotnet action install for us.

@dylan-smith dylan-smith enabled auto-merge (squash) May 13, 2023 20:34
@dylan-smith dylan-smith merged commit 0e9775c into main May 13, 2023
@dylan-smith dylan-smith deleted the dependabot/github_actions/actions/setup-dotnet-3 branch May 13, 2023 20:46
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Octoshift 86% 75% 1134
bbs2gh 82% 79% 645
ado2gh 84% 82% 671
gei 85% 82% 744
Summary 85% (7008 / 8231) 79% (1752 / 2222) 3194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant