Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double the time waiting post replication restart #1421

Closed
wants to merge 36 commits into from
Closed

Double the time waiting post replication restart #1421

wants to merge 36 commits into from

Conversation

andyedison
Copy link
Contributor

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue:

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR increases the startSlavePostWaitMilliseconds as we are seeing an error when running gh-ost in some cloud environments that the Slave_IO_Running is Connecting rather than Yes as expected.

We found this old PR that described the issue we're having #337 - as a first step we are increasing by doubling the value. If this test is successful, then we'll look into making this something that could be configured.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

testwill and others added 30 commits December 7, 2023 15:50
@testwill @timvaillancourt
fix: typo (#1331)
fe9d8d1 
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Remove stale RELEASE_VERSION file (#1349)
fa12f44 
Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>
@timvaillancourt @meiji163
Force index in unique key range queries (#1237)
b22229f 
* WIP

* Pass entire sql.UniqueKey

* newline for limit

* Rename var

---------

Co-authored-by: meiji163 <meiji163@github.com>
@timvaillancourt
Include git commit in version (#1347)
d90112c 
* Include git commit in version

Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>

* Make --version output change less-breaking

---------

Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>
@timvaillancourt
Fix tokens in inspector logging (#1226)
347d8e0
@timvaillancourt
Cleanup whitespace and comments in SQL query text (#1246)
5ebb953 
* Cleanup whitespace in SQL query text

* cleanup

* Add indent

* Update unit tests

* Update unit tests, pt 2

* Fix tweaks

* Fix merge conflict resolution

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Fix --version output (#1352)
679d39e 
* Fix `--version` output

Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>

* Always fallback version/commit if undef

Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>

---------

Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>
@timvaillancourt
Update to go1.21 (#1351)
462930f 
* go1.21 + bullseye

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* go1.21 + bullseye pt 2

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* checkout before setup-go

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* go fmt

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Use golangci-lint 1.54.2 to support go1.21

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* stop using io/ioutil to make linter happy

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix typo

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Lint

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* revert replica-tests CI to ubuntu 20 due to linker errors

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Update ensure-go-installed

* use `ubuntu-latest` for `ci` job

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* stretch -> bullseye

Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tvaillancourt@slack-corp.com>
@timvaillancourt
Replace deprecated github.com/satori/go.uuid lib (#1354)
8f9c384 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Add CODEOWNERS file to auto-request reviews (#1350)
59fd18d 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Fix successive failures error in streamer (#1371)
11d66d8
@dm-2
Update CODEOWNERS
51c1a21 
Remove `@dm-2` as I am no longer a maintainer for gh-ost.
@icyflame
Print status to migration context logging after escaping % character (#…
a6cddf9 
…1374)
@dm-2
Merge branch 'master' into update-codeowners
6f09ee0
@dm-2
Merge pull request #1375 from github/update-codeowners
3aa6912 
Update CODEOWNERS
@timvaillancourt @meiji163
Add cpu-profile interactive command (#1358)
b1aae87 
* Add cpu-profile interactive command

* better doc markdown

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* set block profile after isProfiling=1

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* improve test

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* check isCPUProfiling later

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Cleanup

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix discrepancy

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* move base64 to .applyServerCommand(...)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
@shaohk
Support to config charset and collation (#1368)
aa010a0 
* feat(feat-config-connection-charset): support config connection charset

* feat(feat-config-connection-charset): feat-config-connection-charset

The ability to specify character set and collation is supported.

---------

Co-authored-by: shaohoukun <shaohoukun@meituan.com>
@sentinel @meiji163
Add Dependabot config file (#1213)
17149b9 
Co-authored-by: meiji163 <meiji163@github.com>
@dependabot @meiji163
Bump CodeQL actions (#1391)
a05f32f 
* Bump actions/upload-artifact from 1 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v1...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* update codeQL action

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: meiji163 <meiji163@github.com>
@dependabot @meiji163
Bump actions/setup-go from 4 to 5 (#1395)
6b3c6ba 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: meiji163 <meiji163@github.com>
@dependabot
Bump golangci/golangci-lint-action from 3 to 4 (#1392)
27a672d 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@timvaillancourt @meiji163
Update pinned deps (#1355)
9ca2499 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
@shaohk @timvaillancourt @meiji163
Fix binlog end log pos over lost data (#1367)
48b34bc 
* fix(fix binlog end-log-pos over 4g lost data): fix binlog end-log-pos over 4g lost data

* fix(fix-binlog-end-log-pos-over-lost-data): fix-binlog-end-log-pos-over-lost-data

Calculate whether the binlog log_pos overflows beyond 4G using end_log_pos and event_size.

* fix(x): x

x

* test(fix-binlog-end-log-pos-over-lost-data): add unit test

* fix(fix-binlog-end-log-pos-over-lost-data): x

x

* Update binlog.go

change IsLogPosOverflowBeyond4Bytes comment.

* Update binlog.go

x

* fix(fix-binlog-end-log-pos-over-lost-data): fix doc

x

---------

Co-authored-by: shaohoukun <shaohoukun@meituan.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
@dontstopbelieveing @timvaillancourt
Update the description of the max-lag-millis in docs (#1388)
bc6cd55 
* Update description for max-lag-millis in command-line-flags.md

* Update command-line-flags.md

---------

Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Add --mysql-wait-timeout flag (#1401)
c681f61
@timvaillancourt
Add doc for PR #1401 (#1403)
329b13d 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt @meiji163
Update to go1.22, update core deps to latest-stable (#1404)
e6c198c 
* Update to go1.22, update core deps to latest-stable

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* update script/ensure-go-installed

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* git add vendor --all

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* go 1.22.0

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
@mountcount @timvaillancourt
chore: fix function names in comment (#1405)
8d99e46 
Signed-off-by: mountcount <cuimoman@outlook.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
@dependabot
Bump golangci/golangci-lint-action from 4 to 6 (#1414)
e87e2ab 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 6.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v4...v6)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@overallteach
chore: fix some function names (#1417)
59db6fa 
Signed-off-by: overallteach <cricis@foxmail.com>
@andyedison andyedison requested a review from meiji163 June 11, 2024 19:30
@andyedison
Copy link
Contributor Author

Targeted the wrong branch > will use #1422

@meiji163
Copy link
Contributor

Closing in favor of #1422

@meiji163 meiji163 closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meiji163 meiji163 meiji163 approved these changes

@drogart drogart drogart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.