Tweak the testcontainers setup #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurschreiber
requested review from
rashiq,
meiji163 and
timvaillancourt
as code owners
meiji163
previously approved these changes
Oct 23, 2024
meiji163
previously approved these changes
Oct 23, 2024
…/tweak-testcontainers
meiji163
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to improve the testcontainers ergonomics.
SkipPortValidationon the migration context. This is only used internally and allows skipping the port validation, which is useful with MySQL containers running in docker with a randomly assigned "external" port.script/cibuildreturns with no formatting errors, build errors or unit test errors.