responding to errors in rowcopy #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
temporarily deployed
to
production/mysql_role=ghost_testing
This was referenced Jul 11, 2017
Closed
|
tested in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #444
not all rowcopy errors were handled. While errors in row copying had retries, the entire process was not reporting back (as it is being executed in a goroutine).
As result, significant errors such as killed connections were wrongly interpreted as "copy complete" leading to missing rows, i.e. data corruption.
This PR identifies such errors and bails out the migration altogether (having executed
default-retirestimes).