ghost/changelog/del table names support max characters limit #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurnn
reviewed
Jul 21, 2017
| context.StartTime, _ = time.Parse(longForm, "Feb 3, 2013 at 7:54pm (PST)") | ||
| oldTableName := context.GetOldTableName() | ||
| test.S(t).ExpectEquals(oldTableName, "_a1234567890123456789012345678901234567890123_20130203195400_del") | ||
| } |
There was a problem hiding this comment.
I am wondering in splitting this tests into different methods. When adding new tests here I got some mixed results because the context was mutated already.
WDYT?
There was a problem hiding this comment.
@arthurnn sure!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR it's OK for the original table name to be very long, and up to maxlen (
64characters).The old, ghost and changelog names are truncated as needed to accommodate.
Furthermore, the truncation happens on the table name part, rather than on the suffix. To illustrate, this table name:
is
63characters long. The namesgh-ostwill pick are:Furthermore, if using
--timestamp-old-tablethe suffix is even longer, and this truncates even more of the original name, e.g: