Support Azure Database for MySQL #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shlomi-noach , would you mind to review this PR? Thanks, |
|
@elemount these changes look good but I don't have cycles to test on Azure Can you confirm this works in tests on a real Azure database? |
|
Hello, @elemount, @timvaillancourt |
timvaillancourt
temporarily deployed
to
production/mysql_role=ghost_testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #806
Description
This PR will support
gh-ostrun on Azure Database for MySQL. Like GCP or Aliyun RDS, Azure Database also need to do some specific things with code modification. This PR including 3 thingsscript/cibuildreturns with no formatting errors, build errors or unit test errors.